Steps to replicate the issue (include links if applicable):
What happens?:
Multiple places in the document get a thick red outline.
What should have happened instead?:
At most a single place should get a red outline, because there must be no duplicate id attributes.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Prevent duplicate ids in nested fields | mediawiki/extensions/CommunityConfiguration | master | +83 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Michael | T363855 Improve validation errors wording and behavior | |||
| Resolved | BUG REPORT | Michael | T365129 Special:CommunityConfiguration/GrowthSuggestedEdits has many duplicate HTML id attributes |
@Michael: Assuming this task is about the #GrowthExperiments-CommunityConfiguration code project, hence adding that project tag so other people can also find this task when searching via projects or looking at workboards. Please set appropriate project tags when possible. Thanks!
Since the naming confused many people, I took the liberty of renaming the GrowthExperiments- prefixed project to GrowthExperiments-EditGrowthConfig, so that it better explains what it actually covers. This task is about MediaWiki-extensions-CommunityConfiguration (an extension separate from GrowthExperiments).
Thank you both, @Aklapper and @Urbanecm_WMF. I must have been distracted when creating this task and forgot the phab projects.
Change #1034505 had a related patch set uploaded (by Michael Große; author: Michael Große):
[mediawiki/extensions/CommunityConfiguration@master] Prevent duplicate ids in nested fields
The same is true for Special:CommunityConfiguration/HelpPanel. And probably Mentorship and Homepage should be reviewed as well.
Incorporating the suggestions by @Sgs, it should now be properly working and be ready to review.
Change #1034505 merged by jenkins-bot:
[mediawiki/extensions/CommunityConfiguration@master] Prevent duplicate ids in nested fields
I verified that this is fixed on https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CommunityConfiguration/HelpPanel#GEHelpPanelLinks.1 and https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CommunityConfiguration/GrowthSuggestedEdits
I don't think there is much of a point for this to go through QA. This will be part of the parent task.