Relevant slack thread: https://wikimedia.slack.com/archives/C03DKGSEPL2/p1718118281881219

See T367161#9906578

We may need to add sort keys for the date column to properly sort, as it's by default alphabetical.

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/91

Add hidden table sort key for created date

@Samwilson Please review the RTL gif below, thanks!

Test Result - Wishlist-test.toolforge

Status: ✅ PASS
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Enable Sorting by Date, Status, and Type

1. Open Wikipedia on the Minerva skin and navigate to the wish index page.
2. Click the "Date" column header to sort by date.
3. Click the "Status" column header to sort by status.
4. Click the "Type" column header to sort by type.

✅ AC1: Confirm that the table sorts correctly by date, status, and type.

❌AC2: Confirm that the table sorts correctly by date, status, and type with RTL.

• Sorting does not work. I
• I'm sure you mentioned it before, but the sort button is close to the headers.
• The table visually should look the same even when in RTL, correct? Meaning, the order shouldn't change

Thanks for testing! I forgot that this was dependent on T368578. Stalling now pending that task's resolution.

That task is done, and I think there's some more work to be done here: the table should be displayed in the content language, but we're handling the sorting according to the interface language (e.g. Wishes/en?uselang=ar shows the sorting arrows on the left, and Wishes/ar?uselang=en shows them on the right; both are incorrect).

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/120

Move tablesorter icons to left for RTL langs

Sorting does not work.
I'm sure you mentioned it before, but the sort button is close to the headers.
The table visually should look the same even when in RTL, correct? Meaning, the order shouldn't change

Sorting should now be working correctly, including for RTL.

The issue with the RTL sort button has been fixed, but note this issue: T369592: TableSorter icon follows interface lang instead of content lang (so only expect the sort icon to swap sides when you change the interface language, not when you view a RTL translation page of a wish).

@Samwilson Please review the RTL gif and the possible issue below, thanks!

Test Result - Wishlist-test.toolforge

Status: ✅ PASS
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Enable Sorting by Date, Status, and Type

1. Open Wikipedia on the Minerva skin and navigate to the wish index page.
2. Click the "Date" column header to sort by date.
3. Click the "Status" column header to sort by status.
4. Click the "Type" column header to sort by type.

✅ AC1: Confirm that the table sorts correctly by date, status, and type.

❌AC2: Confirm that the table sorts correctly by date, status, and type with RTL.

• Sorting does not work. I
• I'm sure you mentioned it before, but the sort button is close to the headers.
• The table visually should look the same even when in RTL, correct? Meaning, the order shouldn't change

❓ Possible Issue

"Community Wishlist is an ongoing survey that allows contributors to the Wikimedia projects to propose and support tools and platform improvements. Users are welcomed to propose their own wishes at any time and also can show support of other wishes submitted by the community." does not move when it's RTL as seen in the gif below. I'm not sure if there is a task on this already or if there should be one created.

"Community Wishlist … by the community." does not move when it's RTL as seen in the gif below. I'm not sure if there is a task on this already or if there should be one created.

No, that's fine, it follows the page language and not the interface language. The same as when you view an Arabic page with the interface set to English, the content is RTL.

❌AC2: Confirm that the table sorts correctly by date, status, and type with RTL.

Thanks! I think I've fixed it this time. So there are four states, and the normal table sorter handles them like this:

So we should do the same.

tstarling merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/212

Try again to fix sortable table headers

Merged, and the test site updated. @GMikesell-WMF can you have another look? Thanks!

@Samwilson Please review to see if the below is fine. Also "en" and "he" interfaces seem to be fine when the page language is English but not Hebrew? Also ?uselang=en-rtl doesn't sort, is that fine since "he" is working? If these are fine than you can move it to Done.

Test Result - Wishlist-test.toolforge

Status: ✅ PASS
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

I couldn't test he?uselang=he and he?uselang=en as seen in the screenshots.
Gifs are for page language "en" with the interface of "en" and "he"

Interface lang ↓ / Page lang →	en	he
en
he

Oh oops yes sorry, I was testing with he on my local, but should've changed those to ar on the test wiki. The he/he combo is the same as ar/ar: https://wishlist-test.toolforge.org/wiki/Community_Wishlist/Wishes/ar?uselang=ar

But yep, I think everything's good here. We can revisit if anyone finds any issues, or if the TableSorter issue gets worked on.

Thanks!