Page MenuHomePhabricator

Cannot upload! – TypeError: Cannot read properties of undefined (reading 'dataValueType')
Closed, ResolvedPublicPRODUCTION ERROR

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • I cannot upload
  • Notice that not a single input field is shown on the description step of the upload wizard
  • Notice the following error on the JavaScript console
jQuery.Deferred exception: Cannot read properties of undefined (reading 'dataValueType') TypeError: Cannot read properties of undefined (reading 'dataValueType')
    at https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:246:115
    at Array.forEach (<anonymous>)
    at mw.UploadWizardDetails.buildInterface (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:246:16)
    at mw.UploadWizardDetails.attach (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:251:280)
    at https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:73:794
    at Array.forEach (<anonymous>)
    at uw.controller.Details.load (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:73:650)
    at uw.controller.Step.moveNext (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:64:383)
    at Array.<anonymous> (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:67:925)
    at mightThrow (https://commons.wikimedia.org/w/load.php?lang=de&modules=jquery%2Coojs-ui-core&skin=vector-2022&version=1d0dx:45:648)

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

  • MediaWiki 1.43.0-wmf.11 (7df99f2) 2024-06-24T20:36:14
  • Upload Wizard 1.5.0 (a8c7f4a) 2024-06-24T17:59:10

Other information (browser name/version, screenshots, etc.):

Regression of T361053?
Regression of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/1047126?

commons.wikimedia.org_wiki_special_uploadWizard_campaign=Schallaburg2024-at&fields%5B%5D=Q37940540.png (1×1 px, 301 KB)

Event Timeline

We are running our annual photo competition WikiDaheim (starting with July, 1st), which is highly based on a working UW.

Aklapper changed the subtype of this task from "Bug Report" to "Production Error".

Change #1051695 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Handle campaigns where wikibase is not enabled

https://gerrit.wikimedia.org/r/1051695

Change #1051695 abandoned by Cparle:

[mediawiki/extensions/UploadWizard@master] Handle campaigns where wikibase is not enabled

Reason:

wrong branch

https://gerrit.wikimedia.org/r/1051695

Change #1051696 had a related patch set uploaded (by Matthias Mullie; author: Cparle):

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.12] Handle campaigns where wikibase is not enabled

https://gerrit.wikimedia.org/r/1051696

Good catch @simon04 thank you! Fix scheduled for deployment at 1300UTC

Change #1051696 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.12] Handle campaigns where wikibase is not enabled

https://gerrit.wikimedia.org/r/1051696

Are you already deploying the backport now? Otherwise it shouldn’t have been merged yet IIUC.

Mentioned in SAL (#wikimedia-operations) [2024-07-03T09:18:56Z] <mlitn@deploy1002> Started scap sync-world: Backport for [[gerrit:1051696|Handle campaigns where wikibase is not enabled (T369085)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-03T09:21:29Z] <mlitn@deploy1002> mlitn: Backport for [[gerrit:1051696|Handle campaigns where wikibase is not enabled (T369085)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-03T09:31:56Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:1051696|Handle campaigns where wikibase is not enabled (T369085)]] (duration: 12m 59s)

as far as I can judge, everything is back to normal. Thanks

Cparle claimed this task.