Better handle `TOC` in parser tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Mar 17 2015, 7:40 PM

Description

Since the Parsoid DOM doesn't include TOC information, by design, we should go through all the parser tests which mention __TOC__ and make them Parsoid-compatible. Either (1) making them PHP-only, or (2) adding trivial html/parsoid clauses, self-documenting that Parsoid doesn't emit TOC info, or (3) adding some sort of "TOC normalization" to our normalization utility, to remove TOC markup.

(Note that there's also an issue with empty <p></p> being generated by the PHP TOC, see T92892, which might complicate option 3.)

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.18.0-a7	mediawiki/vendor	master	+691 -587
	Add synthetic TOC if necessary	mediawiki/services/parsoid	master	+337 -237

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Resolved		ovasileva	T283505 [EPIC] Fixed "sticky" site header
Resolved		• ssastry	T270199 Table of contents in Parsoid output
Resolved		• ssastry	T92999 Better handle `__TOC__` in parser tests

Event Timeline

cscott created this task.Mar 17 2015, 7:40 PM

cscott raised the priority of this task from to Needs Triage.

cscott updated the task description. (Show Details)

cscott added a project: Parsoid.

cscott subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 7:40 PM

Arlolra triaged this task as Medium priority.Mar 17 2015, 8:05 PM

Arlolra subscribed.

Kelson subscribed.Oct 15 2015, 6:24 PM

• ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 18 2017, 10:06 PM

Arlolra mentioned this in T270199: Table of contents in Parsoid output.Dec 15 2020, 6:11 PM

Given the intent to implement TOC in Parsoid (T270199), probably the correct thing to do is add a 'toc' flag to the !!options to opt-in to the toc post-processing step (when that gets implemented).

MBinder_WMF added a project: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Sep 16 2021, 5:15 PM

cscott moved this task from Backlog to Tech Debt on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Jan 26 2022, 7:56 PM

• JMcLeod_WMF moved this task from Tech Debt to Backlog on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.May 16 2022, 3:51 PM

• ssastry closed this task as Resolved.Mar 31 2023, 4:08 AM

• ssastry reopened this task as Open.

• ssastry claimed this task.

• ssastry added a project: Content-Transform-Team-WIP.

• ssastry moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.

• ssastry moved this task from Backlog to To Verify on the Content-Transform-Team-WIP board.Mar 31 2023, 4:14 AM

cscott moved this task from To Verify to In Progress on the Content-Transform-Team-WIP board.Apr 3 2023, 3:13 PM

Change 903797 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Add synthetic TOC if necessary