Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (Wikimedia Performance)Administrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (509 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photo by Niek Hidding.)

Recent Activity

Wed, Jul 10

Krinkle added a comment to T116561: Position of boolean operators inside an if condition.

https://www.mediawiki.org/wiki/Manual:Coding_conventions#Line_continuation currently reflects this by saying "The operator separating the two lines should be placed consistently (always at the end or always at the start of the line)."

Wed, Jul 10, 3:18 AM · Patch-Needs-Improvement, MediaWiki-Codesniffer

Tue, Jul 9

Krinkle edited projects for T265650: Enable strict units in LESS, added: MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
Tue, Jul 9, 11:32 PM · MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader
Krinkle edited projects for T265650: Enable strict units in LESS, added: MediaWiki-ResourceLoader; removed MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-General.
Tue, Jul 9, 11:31 PM · MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader
Krinkle updated subscribers of T341560: Migrate mwmaint server functionality to mw-on-k8s.

How can MW developers access the output of currently-runinng (or recently-completed) scheduled maintenance scripts that execute in Kubernetes?

Tue, Jul 9, 8:55 PM · serviceops, MW-on-K8s

Mon, Jul 8

Krinkle added a comment to T333276: Add flip for shorthand properties that contain calc() expressions.

@Ebrahim That is a very large patch indeed. Fortunately, that is a link to a mostly unrelated (and not merged) pull request to solve a different issue.

Mon, Jul 8, 7:45 PM · MediaWiki-Platform-Team, Performance-Team, CSSJanus
Krinkle added a comment to T353817: Create legacy EventLogging proxy HTTP intake (for MediaWikiPingback) endpoint to EventGate.

Move docroot/mediawiki.org/beacon/event/index.php to w/beacon.php

@Joe, to not squat w/beacon.php, in case there are other usages of /beacon that we'd want to route, would this perhaps be better at w/beacon/event.php

Mon, Jul 8, 6:55 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-Platform-Team (Radar), Data-Engineering, Event-Platform, MediaWiki-General
Krinkle added a comment to T367392: Message blob for {module} should have been preloaded.

Questions to think about:

  • When looking for the normalized message across mediawiki-errors Logstash dashboard, does it affect specific domains, hosts, data centers, or {module} values more than others?
  • How long do the peaks last?
  • Does it have literally zero ocurrences outside the peaks, or is there a continuous trickle at a lower level as well?
  • Do the peaks happen at a regular interval?
  • Do the recurring peaks align with any recurring SAL entries?
Mon, Jul 8, 2:33 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
Krinkle updated the task description for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 8, 2:14 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle added a project to T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) : MediaWiki-Platform-Team (Radar).
Mon, Jul 8, 2:06 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle updated the task description for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 8, 2:05 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle renamed T369373: Less.php: Unable to run bootstrap-3.0.3 benchmark from LessPHP: Unable to compile bootstrap-3.0.3 library with strictMath=true to Less.php: Unable to run bootstrap-3.0.3 benchmark.
Mon, Jul 8, 1:06 PM · MediaWiki-Platform-Team, Less.php
Krinkle closed T369373: Less.php: Unable to run bootstrap-3.0.3 benchmark as Resolved.
Mon, Jul 8, 1:05 PM · MediaWiki-Platform-Team, Less.php

Sat, Jul 6

Krinkle closed T362216: Unable to set JavaScript breakpoints in gadget code when using ?debug=1 as Resolved.
Sat, Jul 6, 4:48 AM · Developer Productivity, MediaWiki-Platform-Team, MediaWiki-ResourceLoader

Fri, Jul 5

Krinkle added a comment to T369373: Less.php: Unable to run bootstrap-3.0.3 benchmark.

The bootstrap-3.0.3 test case is enabled in CI and thus passing in the context PHPUnit and compare.php as a fixture:

Fri, Jul 5, 5:20 PM · MediaWiki-Platform-Team, Less.php
Krinkle added a comment to T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .

Can you write a stylelint-config-wikimedia rule to detect (and ideally auto-fix) this?

Fri, Jul 5, 1:24 AM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle updated subscribers of T352885: Enable extstore to a subset of memcached servers (experiment).

We discussed this in the MwEng-SvcOps meeting (13 June 2024). Extstore was enabled on a few hosts in the DC. Some stats differered, but we weren't able to come up with a testing strategy to prove or disprove an observable benefit from the MW application in this state since keys are sharded across all hosts, and traffic generally involves many different keys.

Fri, Jul 5, 12:30 AM · MediaWiki-Platform-Team (Radar), serviceops

Thu, Jul 4

Krinkle claimed T361412: Write PHPUnit tests for excimer-ui-client (WikimediaDebug).
Thu, Jul 4, 10:26 PM · SRE Observability (FY2023/2024-Q4), MediaWiki-Platform-Team (Radar), WikimediaDebug

Wed, Jul 3

Krinkle closed T361070: Performance review of CommunityConfiguration as Resolved.

Marking this as resolved since the review was completed above. Feel free to ping me in Phab or Gerrit with questions on follow-up work, or ask in our team channel on IRC.

Wed, Jul 3, 2:23 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), MediaWiki-extensions-CommunityConfiguration, Growth-Team, MediaWiki-Platform-Team

Tue, Jul 2

Krinkle added a project to T308732: Cleanup interaction between per-job and root-job deduplication logic so they mix properly: MW-Interfaces-Team.

Re-tagging for triage. Up to team to triage accordingly. (I'm cleaning up an old note pad, this isn't time-sensitive or related to me.)

Tue, Jul 2, 4:14 PM · MW-Interfaces-Team, Wikimedia-Performance-recommendation, Foundational Technology Requests, Platform Engineering, Patch-For-Review, MediaWiki-Core-JobQueue

Mon, Jul 1

Krinkle added a comment to T366005: Remove docroot/wikimediafoundation.org/ folder from mediawiki-config.

/docroot/wikimediafoundation.org/.well-known contains a matrix/server file.

Mon, Jul 1, 10:15 PM · Patch-For-Review, SecTeam-Processed, Security-Team, Wikimedia-Apache-configuration, Security
Krinkle updated the task description for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 3:46 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle updated the task description for T366445: Add support for Maths(strictMath) option when it is set to parens-division.
Mon, Jul 1, 3:19 PM · MediaWiki-Platform-Team, Less.php
Krinkle updated the task description for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 3:17 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle updated the task description for T366445: Add support for Maths(strictMath) option when it is set to parens-division.
Mon, Jul 1, 3:16 PM · MediaWiki-Platform-Team, Less.php
Krinkle edited projects for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) , added: MediaWiki-HTMLForm, MediaWiki-Recent-changes, MinervaNeue, SDAW-MediaSearch, GrowthExperiments, MediaWiki-User-Interface, MobileFrontend, ContentTranslation, StructuredDiscussions, Desktop Improvements (Vector 2022), Web-Team-Backlog, Advanced-Search, CheckUser, DiscussionTools, Notifications, Maps (Kartographer), Page-Previews, UniversalLanguageSelector, UploadWizard, WikiLambda, WikibaseMediaInfo; removed WMF-General-or-Unknown, MediaWiki-General.
Mon, Jul 1, 3:10 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle updated the task description for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 3:08 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle updated the task description for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 3:08 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle renamed T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) from Migrate bare slash-division math to parens-division in Less styles (in WMF-deployed extensions) to Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 2:56 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle added a subtask for T288498: Update less.php port to support Less.js 3.13 behaviours: T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 2:55 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Krinkle added a parent task for T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) : T288498: Update less.php port to support Less.js 3.13 behaviours.
Mon, Jul 1, 2:55 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm
Krinkle created T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Mon, Jul 1, 2:55 PM · LPL Essential (LPL Essential 2024 Jul-Sep), MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), Abstract Wikipedia team, WikibaseMediaInfo, WikiLambda, UploadWizard, UniversalLanguageSelector, Page-Previews, Maps (Kartographer), Notifications, DiscussionTools, CheckUser, Advanced-Search, StructuredDiscussions, ContentTranslation, MediaWiki-User-Interface, GrowthExperiments, SDAW-MediaSearch, Structured-Data-Backlog, MediaWiki-Recent-changes, Growth-Team, MediaWiki-HTMLForm

Thu, Jun 27

Krinkle added a comment to T353817: Create legacy EventLogging proxy HTTP intake (for MediaWikiPingback) endpoint to EventGate.

This redirect is coming from Apache and known as DirectorySlash. It's a way to make sure that directory index responsees have a reliable and consistent way that relative images, hyperlinks, etc are resolved.

Thu, Jun 27, 11:01 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-Platform-Team (Radar), Data-Engineering, Event-Platform, MediaWiki-General

Wed, Jun 26

Krinkle closed T367186: Add support for less.js 3.0 calc() exception, a subtask of T288498: Update less.php port to support Less.js 3.13 behaviours, as Resolved.
Wed, Jun 26, 10:36 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Krinkle closed T367186: Add support for less.js 3.0 calc() exception as Resolved.
Wed, Jun 26, 10:35 PM · Patch-For-Review, MediaWiki-Platform-Team, Less.php
Krinkle added a project to T359849: Write and send release announcement for 1.42.0: MediaWiki-Engineering.
Wed, Jun 26, 9:02 PM · MediaWiki-Engineering, MW-1.42-release, MediaWiki-Releasing
Krinkle awarded T368550: castor does not restore caches? a Orange Medal token.
Wed, Jun 26, 4:24 PM · Castor, Continuous-Integration-Infrastructure
Krinkle added a comment to T362425: ForeignResourceStructureTest flaky in CI due to "Failed to download resource at https://codeload.github.com".

Is it possible to specify a fallback source […] only used in CI context?

In a change where the foreign resources are touched, […].

In a change where the foreign resources aren’t touched, I think the test serves almost no purpose […].

Wed, Jun 26, 2:59 PM · MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), ci-test-error (WMF-deployed Build Failure), Continuous-Integration-Infrastructure

Tue, Jun 25

Krinkle triaged T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does) as Low priority.
Tue, Jun 25, 2:41 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer
Krinkle added a comment to T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does).

(Moving per Roan's comment on Gerrit. Awaiting updated patch before I can re-review/test.)

Tue, Jun 25, 2:41 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer
Krinkle moved T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does) from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.
Tue, Jun 25, 2:40 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer

Mon, Jun 24

Krinkle added a comment to T242712: Deprecation (if possible) of the #central channel on irc.wikimedia.org.

SULWatcher does not rely on creations happening on login.wikimedia.org. In reviewing its code, I find that it is using stream.wikimedia.org and looking across all wikis for newusers log events

Really!? Interesting. Link to code?

Mon, Jun 24, 7:11 PM · Data-Engineering-Icebox
Krinkle added a comment to T242712: Deprecation (if possible) of the #central channel on irc.wikimedia.org.

In light of T348388, I'm checking to make sure SULWatcher does not rely on creations happening on login.wikimedia.org. In reviewing its code, I find that it is using stream.wikimedia.org and looking across all wikis for newusers log events. The reason this doesn't double report auto creations is that autocreation skips the RC publish step (as detailed in T242712#5858564). Even if we did RC_publish them, SULWatcher coudl be easily fixed by checking for newusers/create specifically since we do differiate that subtype from newusers/autocreate already.

Mon, Jun 24, 5:07 PM · Data-Engineering-Icebox
Krinkle awarded T183999: Scap canary has a shifting baseline a Love token.
Mon, Jun 24, 4:48 PM · Release-Engineering-Team (Seen), Scap

Sat, Jun 22

Krinkle added a comment to T368204: Consider removing new-line insertion from JavaScriptMinifier.

I'm proposing this as a maintenance task next quarter to take on between Hannah and Derick (writing and review, respectively).

Sat, Jun 22, 8:14 PM · MediaWiki-Platform-Team, Wikimedia-Minify
Krinkle triaged T368204: Consider removing new-line insertion from JavaScriptMinifier as Medium priority.
Sat, Jun 22, 8:08 PM · MediaWiki-Platform-Team, Wikimedia-Minify
Krinkle added a comment to T368204: Consider removing new-line insertion from JavaScriptMinifier.

These are examples of issues that this improvement would have avoided or reduced the priority of:

Sat, Jun 22, 8:08 PM · MediaWiki-Platform-Team, Wikimedia-Minify
DannyS712 awarded T368204: Consider removing new-line insertion from JavaScriptMinifier a Like token.
Sat, Jun 22, 8:07 PM · MediaWiki-Platform-Team, Wikimedia-Minify
Krinkle created T368204: Consider removing new-line insertion from JavaScriptMinifier.
Sat, Jun 22, 8:02 PM · MediaWiki-Platform-Team, Wikimedia-Minify

Fri, Jun 21

Krinkle added a comment to T366917: performance-asoranking service broken on stat1011.

[…]
So I suspect that it should still be fixed. The repository from where the code runs is here: https://gerrit.wikimedia.org/g/performance/asoranking
@Krinkle was the last person to commit to that repository, so may know more about this report and what should happen to it.

Fri, Jun 21, 1:33 PM · Data-Platform-SRE (2024.06.17 - 2024.07.07)

Thu, Jun 20

Krinkle awarded T340457: In UserGroupManager::getUserImplicitGroups, add temporary users to a 'temp' group instead of the 'user' group a Orange Medal token.
Thu, Jun 20, 4:50 PM · MW-1.41-notes (1.41.0-wmf.16; 2023-07-04), MediaWiki-User-management, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Temporary accounts

Wed, Jun 19

Krinkle added a comment to T241389: Enotif_body says you can contact a user in userspace, and it should probably link to the User_talk: namespace instead.

I think in the past it was not uncommon for power users on larger wiki farms (i.e. Wikipedia and WMF projects) to have a user page indicating preferered ways to be contacted, especially when they're not active on that wiki. E.g. placeholders like "contact me on Meta-Wiki instead of here as I won't see your message otherwise".

Wed, Jun 19, 11:47 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Growth-Team-Filtering, User-DannyS712, MediaWiki-Watchlist, MediaWiki-Email, Growth-Team
Krinkle added a comment to T366790: Investigate Weird Behaviour Around Google-selected Canonical .

The /zh-cn/ path is for automatic language variant conversion. This is enabled on certain wikis only (incl zh.wikipedia.org). This displays meaningfully different text in the article content body, and gets its own canonical URL in the HTML. E.g. compare https://zh.wikipedia.org/wiki/關東地方 to https://zh.wikipedia.org/zh-sg/關東地方 (linked from the variants menu in the toolbar), which contains notably different characters in the content, and each have their own <link rel=canonical>. This conversation resides close to the Parser and is part of the MediaWiki-Language-converter component, both maintained by the CTT team under MwEng. I don't think this component is playing a role in what URL Google is displaying.

Wed, Jun 19, 9:12 PM · MediaWiki-Interwiki, Chinese-Sites, MediaWiki-Engineering, SEO
Krinkle assigned T266200: TemplateData extension sets non-json-serializable page properties to daniel.

Tagging CTT for scope (ParserOutput support). Tagging @daniel since he started the work previously. Feel free to un-assign or forward if someone else can/should work on this instead.

Wed, Jun 19, 8:21 PM · Content-Transform-Team-WIP, VisualEditor, TemplateData, MediaWiki-Parser
Krinkle added a comment to T266200: TemplateData extension sets non-json-serializable page properties.

From a quick glance, it seems support was added in core. I don't see a change in TemplateData to use it. A draft change for it was abandoned/reverted.

Wed, Jun 19, 8:18 PM · Content-Transform-Team-WIP, VisualEditor, TemplateData, MediaWiki-Parser
Krinkle edited projects for T366790: Investigate Weird Behaviour Around Google-selected Canonical , added: MediaWiki-Interwiki; removed MediaWiki-General.
Wed, Jun 19, 1:47 PM · MediaWiki-Interwiki, Chinese-Sites, MediaWiki-Engineering, SEO

Tue, Jun 18

Krinkle added a comment to T367172: Watchlist formatter is doing a user edit count database query in every row of the result.

The filters are (if I recall correctly) fairly efficient and allow batch queries. Otherwise we could not filter the list of changes by it in production.

Tue, Jun 18, 2:31 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), DBA, MediaWiki-Watchlist, Performance Issue, Regression, Growth-Team

Mon, Jun 17

Krinkle added a comment to T342267: Investigate surprising "10% Other" portion of Analytics Browsers report.

I think "Other" is not a good name for that bucket. […]
But actually, the current "Other" bucket in, say, ("Windows", "iOS", "Android", "Other", ...) does mostly contain requests from "Windows", "iOS", "Android", etc.
So, I think the name is misleading. […]

Mon, Jun 17, 8:13 PM · Data Products (Data Products Sprint 16), Patch-For-Review, Analytics-Data-Problem, MediaWiki-Platform-Team (Radar), Data-Engineering, Data-Engineering-Dashiki
Krinkle added a comment to P65115 T342267 example rollup.

Fake input data to better understand "Idea 1" for T342267.

Mon, Jun 17, 8:10 PM
Krinkle created P65115 T342267 example rollup.
Mon, Jun 17, 7:54 PM
Krinkle updated subscribers of T367441: Remove ResourceLoader debug mode v1.

Might get to this next quarter with @Hokwelum as part of focussing on MW tech debt and onboarding with RL, along with T343492: Phase out SqlModuleDependencyStore.

Mon, Jun 17, 2:47 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle moved T367441: Remove ResourceLoader debug mode v1 from Backlog: non-prioritized to Within 2 Qs on the MediaWiki-Platform-Team board.
Mon, Jun 17, 2:46 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle moved T367441: Remove ResourceLoader debug mode v1 from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Mon, Jun 17, 2:46 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle updated Other Assignee for T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does), added: Krinkle.

The installer has historically been associated as being "for third-party support". In recent history we've reframed this to also be seen as an essential part of Quickstart, dev environment, contributing (e.g. Hackathon events., and onboarding (incl for WMF staff). While this doesn't mean that the installer now has an owner, it does mean it's now more normalized for individual teams to improve/fix things as they see fit when it also benefits these other use cases.

Mon, Jun 17, 2:43 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer
Krinkle closed T366445: Add support for Maths(strictMath) option when it is set to parens-division, a subtask of T288498: Update less.php port to support Less.js 3.13 behaviours, as Resolved.
Mon, Jun 17, 2:37 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Krinkle closed T366445: Add support for Maths(strictMath) option when it is set to parens-division as Resolved.
Mon, Jun 17, 2:37 PM · MediaWiki-Platform-Team, Less.php
Krinkle moved T367187: Introduce ParserInput class from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Mon, Jun 17, 2:22 PM · MediaWiki-Platform-Team, Less.php
Krinkle moved T367186: Add support for less.js 3.0 calc() exception from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Jun 17, 2:22 PM · Patch-For-Review, MediaWiki-Platform-Team, Less.php

Fri, Jun 14

Krinkle updated the task description for T248519: Organise Phabricator tasks about MediaWiki core's ParserCache.
Fri, Jun 14, 7:53 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff, Platform Engineering
Krinkle updated the task description for T248519: Organise Phabricator tasks about MediaWiki core's ParserCache.
Fri, Jun 14, 7:53 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff, Platform Engineering

Thu, Jun 13

Krinkle added a comment to T367194: Citoid/Zotero: Create rate limiting configurable on a per site basis.

Apologies if I'm asking too soon, or if this is already taken into consideration...

Thu, Jun 13, 7:36 PM · VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid
Krinkle moved T53443: Replace "Chosen" jQuery plugin from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Thu, Jun 13, 6:18 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface
Krinkle set the color for Platform Engineering to Red.
Thu, Jun 13, 6:18 PM
Krinkle archived Core Platform Team Initiatives.
Thu, Jun 13, 6:17 PM
Krinkle edited projects for T53443: Replace "Chosen" jQuery plugin, added: MediaWiki-Platform-Team (Radar); removed MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-Platform-Team.

In the FSG meeting yesterday, @Catrope, @lwatson (Design System Team) and myself went through the various ways jquery.chosen is used today (Codesearch). Removal of the module may still be a few releases out as migration is non-trivial and we haven't started deprecation yet. But, keeping it without replacement is cheap. More important is the general direction we want to go in. We agree that we do not want to support a standalone replacement for jquery.chosen. Generally speaking MediaWiki core should not be shipping (new) standalone UI component libraries, besides OOUI/Codex.

Thu, Jun 13, 6:17 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface
Krinkle renamed Core Platform Team Initiatives from Platform Team Initiatives to Core Platform Team Initiatives.
Thu, Jun 13, 6:17 PM
Krinkle edited projects for T53443: Replace "Chosen" jQuery plugin, added: MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Radar).
Thu, Jun 13, 6:16 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface
Krinkle moved T53443: Replace "Chosen" jQuery plugin from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.
Thu, Jun 13, 5:33 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface
Krinkle renamed T53443: Replace "Chosen" jQuery plugin from Replace Chosen with select2 to Replace "Chosen" jQuery plugin.
Thu, Jun 13, 5:28 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface
Jdforrester-WMF awarded T367441: Remove ResourceLoader debug mode v1 a Like token.
Thu, Jun 13, 4:57 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Esanders awarded T367441: Remove ResourceLoader debug mode v1 a Yellow Medal token.
Thu, Jun 13, 4:21 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle created T367441: Remove ResourceLoader debug mode v1.
Thu, Jun 13, 4:17 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader

Wed, Jun 12

Krinkle updated the task description for T367367: PHP Notice: Undefined index: vertical_size_value, horizontal_size_value (from getid3 via TimedMediaHandler).
Wed, Jun 12, 10:28 PM · Unstewarded-production-error, TimedMediaHandler, Wikimedia-production-error
Krinkle created T367367: PHP Notice: Undefined index: vertical_size_value, horizontal_size_value (from getid3 via TimedMediaHandler).
Wed, Jun 12, 10:24 PM · Unstewarded-production-error, TimedMediaHandler, Wikimedia-production-error
Krinkle removed a project from T367103: Media queries using max width breakpoints are not working in Monobook and Fallback skin: Less.php.

Jdlrobson removed a project: MediaWiki-Platform-Team.

Wed, Jun 12, 5:15 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Regression, Web-Team-Backlog (FY2023-24 Q4 Sprint 5), Codex, Design-System-Team
Krinkle added a comment to T367103: Media queries using max width breakpoints are not working in Monobook and Fallback skin.

development of https://github.com/leafo/lessphp seems to be almost stale for 10 years…

Wed, Jun 12, 5:11 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Regression, Web-Team-Backlog (FY2023-24 Q4 Sprint 5), Codex, Design-System-Team
Krinkle reopened T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does) as "Open".
Wed, Jun 12, 4:50 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer

Jun 11 2024

Krinkle added a project to T365803: Turn Interwiki Map page on meta into JSON: MediaWiki-Platform-Team (Radar).

Keeping on radar, as I did testing and code review for this and the other stacked patches related to it.

Jun 11 2024, 9:20 PM · MediaWiki-Platform-Team (Radar), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-extensions-WikimediaMaintenance, WMF-General-or-Unknown
Krinkle added a project to T269492: Selecting user language in the REST API: MediaWiki-Platform-Team (Radar).
Jun 11 2024, 9:19 PM · MediaWiki-Platform-Team (Radar), MW-Interfaces-Team, API Platform, MediaWiki-Internationalization, MediaWiki-REST-API
Krinkle removed projects from T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does): MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Patch-For-Review.
Jun 11 2024, 9:15 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer
Krinkle added a project to T283389: MediaWiki installer does not check composer dependencies are at the correct versions (like update.php does): MediaWiki-Platform-Team.
Jun 11 2024, 9:15 PM · Patch-For-Review, MediaWiki-Platform-Team, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Composer, MediaWiki-Installer
Krinkle added a comment to T367186: Add support for less.js 3.0 calc() exception.

As part of a review at https://gerrit.wikimedia.org/r/c/mediawiki/libs/less.php/+/1038745/6/test/Fixtures/lessjs-3.13.1/override/math/strict/css.css#72, I found a change related to calc() that might be relevant or useful.

Jun 11 2024, 7:24 PM · Patch-For-Review, MediaWiki-Platform-Team, Less.php
TBurmeister awarded T239378: Disable parent task metadata by default for new sub tasks a Like token.
Jun 11 2024, 6:50 PM · Patch-For-Review, User-brennen, Release-Engineering-Team, Phabricator, Developer Productivity
Krinkle awarded T364104: Automatically load plugins a Love token.
Jun 11 2024, 6:28 PM · JSDoc WMF theme
Krinkle awarded T265549: Update librsvg to version > 2.44.10 (2.50.3) a Orange Medal token.
Jun 11 2024, 5:51 PM · User-notice-archive, Packaging, Wikimedia-SVG-rendering, Thumbor
Krinkle added a comment to T367194: Citoid/Zotero: Create rate limiting configurable on a per site basis.

Can/does the site in question communicate their enforced limit in an HTTP standardised and machine-readable way? For example, a 429 Status with Retry-After header, or (even better, to avoid hitting a failure first) a crawl limit in robots.txt.

Jun 11 2024, 5:30 PM · VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid

Jun 10 2024

Krinkle added a comment to T367063: Fresh 24.05.1 installer does not remove fresh-node20.

We've previously removed commands when promoting them to the default. Installing both sounds good to me as well. I'd suggest literally installing twice for simplicity and portability of the installer.

Jun 10 2024, 7:17 PM · Fresh
Krinkle triaged T367063: Fresh 24.05.1 installer does not remove fresh-node20 as Medium priority.
Jun 10 2024, 4:10 PM · Fresh
Krinkle updated the task description for T366445: Add support for Maths(strictMath) option when it is set to parens-division.
Jun 10 2024, 2:55 PM · Less.php, MediaWiki-Platform-Team
Krinkle added a comment to T53443: Replace "Chosen" jQuery plugin.

@Ahecht Are you thinking of using this in the context of a gadget?

Jun 10 2024, 2:52 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface
Krinkle updated the task description for T53443: Replace "Chosen" jQuery plugin.
Jun 10 2024, 2:51 PM · MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader, Front-end-Standards-Group, JavaScript, MediaWiki-User-Interface