Page MenuHomePhabricator
Create Task
Maniphest T202763

Update extensions which customize content diff rendering
Open, Needs TriagePublic
Actions

Description

rMWd31580eeb0e9: [MCR] Render multi-slot diffs has deprecated slot-level functionality of DifferenceEngine; most extensions which subclass it should subclass SlotDiffRenderer instead.
In Gerrit, these are:

  • JsonConfig
  • MassMessage
  • MobileFrontend
  • Newsletter
  • ProofreadPage
  • WikEd
  • Wikibase

Details

SubjectRepoBranchLines +/-
Override SlotDiffRenderer instead of DifferenceEnginemediawiki/extensions/MassMessagemaster+200 -98
Add SlotDiffRenderer subclassmediawiki/extensions/Wikibasemaster+261 -209
Override SlotDiffRenderer instead of DifferenceEnginemediawiki/extensions/JsonConfigmaster+45 -46
Override SlotDiffRenderer instead of DifferenceEnginemediawiki/extensions/Newslettermaster+101 -76
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenBUG REPORTNoneT12863 Links on commons upload summaries do not link to commons
 OpenNoneT5498 Image history is confusing
 StalledNoneT96384 Integrate file revisions with description page history
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
 OpenNoneT135221 Make TimedText content an integral part of the File page
 OpenFeatureNoneT2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
 OpenNoneT132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenFeatureNoneT14963 allow per-page exceptions to spam blacklist
 OpenNoneT203157 Make the spam whitelist its own slot
 OpenFeatureNoneT56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
 StalledNoneT174043 Deploy Multi-Content Revisions
 OpenNoneT174022 Implement multi-content revisions
 OpenNoneT189220 Ensure that relevant extensions are MCR-aware
 ResolvedtstarlingT339184 MW core diff review/reorg/refactor
 OpenNoneT202763 Update extensions which customize content diff rendering
 ResolvedNoneT117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
 ResolvedovasilevaT101796 MobileDiff appears strangely empty if previous revision is hidden
 ResolvedJdlrobsonT222562 Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
 ResolvedAmmarpadT224430 Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted)
 OpenNoneT194830 Refactor DifferenceEngine
 ResolvedJdlrobsonT238331 Option for hiding changes should be added to AMC diff display
 ResolvedJdlrobsonT240608 Standardise a control for switching diff types from side by side to inline/visual
 ResolvedphuedxT240622 [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend
 ResolvedJdlrobsonT240624 Style desktop Minerva diff page to look like Special:MobileDiff
ResolvedovasilevaT242310 Regression: issues with MobileDiff
 Resolved• marcellaT242351 HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack)
 ResolvedmatmarexT244673 VisualDiff feature on mobile has an inconsistent style/layout
 ResolvedBUG REPORT• EsandersT245172 VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
 ResolvedovasilevaT243783 MobileDiff drops whitespaces from edits
 ResolvedovasilevaT243235 Regression: Desktop diff styles for moved paragraphs load alongside mobile
 ResolvedJdlrobsonT171726 MobileDiff with inconsistent linebreaks within words
 InvalidNoneT199307 Determine treatment for empty lines in diffs
 Resolved• jkrollT197729 wikidiff2 creating ins and del elements with single empty character element
 OpenFeatureNoneT298174 Diffs should show change tags at lower resolutions
 OpenNoneT218428 Mobile diff is not clear about move direction
 ResolvedJdlrobsonT191706 It's not possible to undo/rollback edits from diff on Mobile
 ResolvedJdlrobsonT347779 Show editor groups and edit count on diff pages
 ResolvedJdlrobsonT347780 Include previous and next links outside the diff columns
 DeclinedNoneT348179 Show bytes added on diff pages
 ResolvedNoneT350181 Enable desktop diff page on mobile site
 ResolvedBUG REPORTSBissonT353404 Wikistory showing on mobile diff page
 ResolvedJdlrobsonT353407 Diff footer is overlaying the text when visual diff is clicked
 ResolvedBUG REPORTJdlrobsonT353478 Diff tables collapse incorrectly on tablet breakpoint
 ResolvedJSengupta-WMFT353479 Diff legend does not display in mobile HTML
 OpenBUG REPORTNoneT361176 visualdiff legend colors are mismatched
 OpenBUG REPORTNoneT353062 Core diff on mobile buggy codex thank button
 ResolvedJdlrobsonT357079 Wrong digit on bnwiki mobile diff

Event Timeline

Tgr created this task.Aug 24 2018, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2018, 6:53 PM
Tgr added a subtask: T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).Oct 3 2018, 3:37 AM
Tgr added a parent task: T189220: Ensure that relevant extensions are MCR-aware.
CCicalese_WMF moved this task from Inbox to Later on the Multi-Content-Revisions board.Oct 3 2018, 7:09 PM
CCicalese_WMF added projects: Platform Engineering (MCR), Platform Team Legacy (Later).Oct 4 2018, 3:08 PM
CCicalese_WMF moved this task from Later to Tech Debt on the Multi-Content-Revisions board.
CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.
WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 2:13 PM
WDoranWMF removed a project: Platform Team Legacy (Later).
WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:37 PM
WDoranWMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).
Tgr mentioned this in T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5].Dec 16 2019, 11:38 PM
tstarling added a parent task: T339184: MW core diff review/reorg/refactor.Jun 21 2023, 12:04 AM
gerritbot added a comment.Jun 27 2023, 4:01 AM

Change 931330 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/JsonConfig@master] Override SlotDiffRenderer instead of DifferenceEngine

https://gerrit.wikimedia.org/r/931330

gerritbot added a project: Patch-For-Review.Jun 27 2023, 4:01 AM
gerritbot added a comment.Jun 27 2023, 4:24 AM

Change 931329 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Newsletter@master] Override SlotDiffRenderer instead of DifferenceEngine

https://gerrit.wikimedia.org/r/931329

gerritbot added a comment.Jun 29 2023, 6:33 AM

Change 934244 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Wikibase@master] Add SlotDiffRenderer subclass

https://gerrit.wikimedia.org/r/934244

gerritbot added a comment.Jun 30 2023, 7:57 PM

Change 931329 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Override SlotDiffRenderer instead of DifferenceEngine

https://gerrit.wikimedia.org/r/931329

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 30 2023, 8:00 PM
gerritbot added a comment.Jul 3 2023, 5:32 AM

Change 934722 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/MassMessage@master] Override SlotDiffRenderer instead of DifferenceEngine

https://gerrit.wikimedia.org/r/934722

gerritbot added a comment.Jul 3 2023, 8:00 AM

Change 931330 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Override SlotDiffRenderer instead of DifferenceEngine

https://gerrit.wikimedia.org/r/931330

gerritbot added a comment.Jul 4 2023, 1:04 PM

Change 934244 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add SlotDiffRenderer subclass

https://gerrit.wikimedia.org/r/934244

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 4 2023, 2:00 PM
gerritbot added a comment.Jul 4 2023, 7:06 PM

Change 934722 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Override SlotDiffRenderer instead of DifferenceEngine

https://gerrit.wikimedia.org/r/934722

Maintenance_bot removed a project: Patch-For-Review.Jul 4 2023, 7:10 PM
Jdlrobson closed subtask T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff) as Resolved.Feb 22 2024, 9:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits