| Aca | |
| Jun 22 2020, 2:17 PM |
| F32189158: Screen Shot 2020-08-19 at 2.15.29 PM.png | |
| Aug 19 2020, 10:02 PM |
| F32189141: Screen Shot 2020-08-19 at 2.47.37 PM.png | |
| Aug 19 2020, 10:02 PM |
| F32186844: mentor dialog with less empty space.png | |
| Aug 17 2020, 7:51 PM |
| F32186622: image.png | |
| Aug 17 2020, 2:40 PM |
| F31905881: Screen Shot 2020-06-25 at 3.18.21 PM.png | |
| Jun 25 2020, 10:19 PM |
Steps to reproduce:
Actual result:
You can see that there is a lot of empty space at the bottom of the box. The problem occurs on all projects that use GrowthExperiments.
Expected result:
There shouldn't be that much empty space. :)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tgr | T256002 Empty space in Ask your mentor dialogue | |||
| Resolved | Tgr | T256908 Homepage: Mentorship module text box should accommodate more text without scrolling |
@Acamicamacaraca: Assuming this task is about the GrowthExperiments-Homepage, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects.
I thought this was intentional (it's from applying the same size constraints we used for the help panel, since the two are sort of the same internally). @RHo am I misremembering?
Hi @Tgr - unfortunately I can't confirm as I was on leave during the design and implementation of the mentor dialog. However, given that this scneraio shows the question inside a centered dialog instead of the help panel which has a specific pinned position and size, I agree with this task to change it standard OOUI dialog window-frame dependent applied height and width:
Example expected dimensions in 1024px wide window:
Change 620772 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Remove large space in homepage mentor dialog and increase question box
Changed to standard OOUI dialog size. This still includes some empty space, but much less:
Change 620772 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove large space in homepage mentor dialog and increase question box
Moving to Design Review in conjunction with T256908: Homepage: Mentorship module text box should accommodate more text without scrolling
 |
Looks good, with same comment as T256908 around allowing vertically resizing of the textarea only as a very minor improvement.